feat: [es] Create docs/contributing/pr-checks.md #6371
Conversation
opentelemetrybot
requested review from
a team and
krol3
and removed request for
a team
|
/fix:fix:dict |
|
fix: failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13415823298. |
|
/fix:dict |
|
fix: failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13659124430. |
|
You triggered fix:dict action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13659233540 |
|
IMPORTANT: (RE-)RUN
|
|
You triggered fix:dict action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13659303754 |
|
IMPORTANT: (RE-)RUN
|
|
/fix:fix:dict |
|
fix: failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13698096387. |
|
/fix:dict |
|
You triggered fix:dict action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13698135935 |
|
IMPORTANT: (RE-)RUN
|
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13698330151 |
|
IMPORTANT: (RE-)RUN
|
There was a problem hiding this comment.
@didiViking: please revert the style (letter case) variations that you've introduced in this page. I'm updating the Localization > Summary notes to make this explicit. That is, when translating you should be faithful to the base English page in both content and style.
You've tagged this page with default_lang_commit: 389e023192e051a3a835bfc6a71089c98af3b8a8, which leads us to the source page at https://github.com/open-telemetry/opentelemetry.io/blob/389e023192e051a3a835bfc6a71089c98af3b8a8/content/en/docs/contributing/pull-requests.md?plain=1.
In the English page there is no cSpell:ignore: REFCACHE front matter, and so there should be no such entry here. You've added ALL CAPS to some heading words that don't exist in the original English. Please revert that.
Also, the base English page has change since you started working on this translation: https://github.com/open-telemetry/opentelemetry.io/compare/f724c15be360e5059fb89e696d9a5cc8d00496f6..43ecc19b51fd86d5b2f30c638f6d734ee8b94932. It might be a good idea to line up with the current page from the start.
I'm noticing that you've made some stylistic variations in this page that are not present in the original
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
|
@theletterf @didiViking - FYI, the following PR introduces a new convention to help localization teams figure out which text not to translate, and it makes updates to the page in this PR: |
|
@chalin I've made the required changes, updating the page to the latest version and commit hash. This should do it I reckon. This was a good PR to get back on the localizatio saddle. 🤠 |
|
/fix:format |
|
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/14038522821 |
|
IMPORTANT: (RE-)RUN
|
|
/fix:format |
|
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/14039266538 |
|
IMPORTANT: (RE-)RUN
|
Related issue: #5205